[WIP] newest dense matmul bindings and change build backend to scikit-build#5
Merged
Transurgeon merged 10 commits intomainfrom Mar 12, 2026
Merged
[WIP] newest dense matmul bindings and change build backend to scikit-build#5Transurgeon merged 10 commits intomainfrom
Transurgeon merged 10 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The updated SparseDiffEngine submodule introduces dense_matrix.c which requires CBLAS. Link Accelerate on macOS, OpenBLAS on Linux, and OpenBLAS via vcpkg on Windows. Install BLAS dev packages in CI via CIBW_BEFORE_BUILD for Linux and Windows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add /usr/include/openblas to include_dirs on Linux so cblas.h resolves in manylinux (CentOS-based) containers where openblas-devel installs headers to /usr/include/openblas/ instead of /usr/include/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CIBW_ENVIRONMENT_WINDOWS values are parsed by shlex, which treats backslashes as escape characters. Use forward slashes instead — Windows accepts them and they survive shlex parsing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the manual setup.py (which compiled ~49 C files with per-platform BLAS logic and Windows workarounds) with a top-level CMakeLists.txt that delegates to the submodule's existing CMake build. This eliminates the dense_matrix_stub.c, the #ifdef _MSC_VER guards in bindings.c, and enables dense matmul support on Windows via vcpkg OpenBLAS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Transurgeon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.